Would recommend stating if it is for an elite controller or standard wireless though, as I bought it for my elite controller and it does not fit.

I got this for a non-Elite Xbox One controller.

The good: the price is right, it's cheaper than the MSFT options, and it works pretty well (haven't owned it long yet but it charges, and powers a controller, which I guess is the important part :)).

The awkward: there are two niggly issues with this battery. These probably won't kill you, but you should be aware.

1. The unit is not like a MSFT one, which is internal to the controller (like 2 x AA batteries). This replaces the controller door as well. If you have a black controller, great! If you have a white controller like me, it looks bad. Fortunately I have a black controller I could swap it to, but be aware it's going to replace your Xbox battery door with its black color scheme. This also leaves you with a spare Xbox controller door hanging around: don't lose it, in case you need to go back to batteries.
2. This doesn't charge via the controller, like a MSFT one. It has its own charge port and charge light. I initially plugged the cable into the controller, not even thinking about it, and was surprised it didn't charge. Silly me, but be aware you need to charge the battery not via the controller. In a way this is a bonus, as you can charge the battery by itself if you need to.

I bought 4 of these and they just won't power any of my 4 standard controllers. I've left them charging for a day by themselves with the provided cable and the controllers don't work at all with them in.